-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Cast to string _flatten_dict
#5354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5354 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 9992 9993 +1
======================================
+ Hits 9309 9310 +1
Misses 683 683 |
_fatten_dict
_flatten_dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add more types to the test besides int
since it's Any
now?
_flatten_dict
_flatten_dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
* fix * params * add test * add another types * chlog Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> (cherry picked from commit 6536ea4)
What does this PR do?
Fixes #5311 <- this links related issue to this PR
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃